fix: datasource save, improve data validation #22038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22038 +/- ##
=======================================
Coverage 67.00% 67.01%
=======================================
Files 1815 1815
Lines 69523 69547 +24
Branches 7479 7479
=======================================
+ Hits 46585 46608 +23
- Misses 21008 21009 +1
Partials 1930 1930
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
approved these changes
Nov 5, 2022
| datasource_post["default_endpoint"] = "http://www.google.com" | ||
| data = dict(data=json.dumps(datasource_post)) | ||
| resp = self.client.post("/datasource/save/", data=data) | ||
| assert resp.status_code == 500 |
There was a problem hiding this comment.
Should we really be expecting 500? This may just be me, but when I see 500, I immediately think "the system borked". Could 422 work better here?
tests/unit_tests/utils/urls_tests.py
Outdated
Comment on lines
42
to
51
| [ | ||
| ("http://localhost/", True), | ||
| ("http://localhost/superset/1", True), | ||
| ("localhost/superset/1", False), | ||
| ("ftp://localhost/superset/1", False), | ||
| ("http://external.com", False), | ||
| ("external.com", False), | ||
| ("///localhost", False), | ||
| ("xpto://localhost:[3/1/", False), | ||
| ], |
There was a problem hiding this comment.
Could we also add an internal and external https:// here?
dpgaspar
deleted the
danielgaspar/sc-61614/superset-fix-add-url-sanitisation
branch
AAfghahi
pushed a commit
that referenced
this pull request
Nov 9, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Nov 18, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Dec 15, 2022
michael-s-molina
pushed a commit
that referenced
this pull request
Jan 5, 2023
mistercrunch
added
🍒 1.5.3
🍒 2.0.1
🚢 2.1.3
🚢 2.1.0
and removed
🍒 2.0.1
🍒 1.5.3
🚢 2.1.3
🚢 2.1.0
labels
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Improves data validation on datasource save, sanitise default endpoint on datasets
ADDITIONAL INFORMATION